From: Catalin Marinas <catalin.marinas@gmail.com>
Date: Fri, 05 Sep 2008 21:35:46 GMT
Subject: Re: [StGIT PATCH] diffcol.sh: Use /bin/bash explicitly
Message-ID: <b0943d9e0809051435g23fa3b83u2a1e8f2a3a6b955f@mail.gmail.com>
In-Reply-To: <20080903162123.GA874@diana.vm.bytemark.co.uk>

2008/9/3 Karl Hasselström <kha@treskal.com>:
> On 2008-09-04 00:47:17 +0900, Shinya Kuribayashi wrote:
>
>> diffcol.sh is based on Quilt, and Quilt is dependent on bash;
>> Actually all Quilt scripts use /bin/bash without exceptions. Then
>> it's good for diffcol.sh to use /bin/bash.
>
> Thanks for this, and the other patch you sent. I'll be picking them up
> this weekend, unless Catalin beats me to it.

BTW, I think at some point we could change to using Git's native
colouring. The diffcol.sh script is from the days when Git didn't have
this feature. We currently generate a diff string and pass it through
the pager but I'm not sure how to do this.

-- 
Catalin