Re: Some ideas for StGIT

From: Catalin Marinas <catalin.marinas@gmail.com>
Date: Aug 6, 2007, 09:49 UTC
Message-ID: <b0943d9e0708060249h4a3f59bobfac8f9014aca82f@mail.gmail.com>
In-Reply-To: <20070803232351.GC30277@nan92-1-81-57-214-146.fbx.proxad.net>

On 04/08/2007, Yann Dirson <ydirson@altern.org> wrote:

Show 10 quoted lines

> On Fri, Aug 03, 2007 at 01:50:10PM -0400, Pavel Roskin wrote:
> >  I see
> > "stg new -s" is supposed to show the changes, but it's currently broken.
> > This is run in a clean StGIT repository with no patches:
> >
> > $ stg new -s foo
>
> Hm, I'm not sure what -s would be supposed to show here, since we're
> asking for the creation of a patch, which currently always starts
> empty.

The story for the 'new -s' option was that with StGIT (not possible with Quilt), one can start modifying the local tree and only create a patch afterwards. The newly created patch is always empty, even if there were local changes and showing them was useful for writing the patch description. One can use refresh for checking the changes in. Indeed, the 'new' command can be improved to have part of the 'refresh' functionality, though I don't really like this duplication.

> Especially confusing is that if there are already applied patches, the
> diff shown is the one of the previous top patch

Are you sure it doesn't only show the local changes (which you might want to add in a new patch)?

> - and if there is no
> applied patches, we get the exception you noticed.

That's a bug, indeed.

> I guess -s should be removed for 0.13.1.

I'll still like to keep it for the rare cases when I use the diff to write the patch description.

Show 6 quoted lines

> I also tried with "stg refresh -m ''" to see if it caused the same
> problem, but it appears to have another problem instead: it does not
> refresh the patch description at all.
>
> My guess is that we should not allow empty patch description (and
> maybe fill it with provided patchname).

I think we should put some default patch description.

-- 
Catalin