Re: Some ideas for StGIT

From: Pavel Roskin <proski@gnu.org>
Date: Aug 6, 2007, 13:26 UTC
Message-ID: <1186406768.10627.50.camel@dv>
In-Reply-To: <b0943d9e0708060249h4a3f59bobfac8f9014aca82f@mail.gmail.com>

On Mon, 2007-08-06 at 10:49 +0100, Catalin Marinas wrote:

> The story for the 'new -s' option was that with StGIT (not possible
> with Quilt), one can start modifying the local tree and only create a
> patch afterwards.

And that's what I really like about StGIT. I like that I can edit code without worrying (too much) about the state of the repository.

Show 5 quoted lines

> The newly created patch is always empty, even if
> there were local changes and showing them was useful for writing the
> patch description. One can use refresh for checking the changes in.
> Indeed, the 'new' command can be improved to have part of the
> 'refresh' functionality, though I don't really like this duplication.

It should be fine as long as the code is reused IMHO.

Show 5 quoted lines

> > Especially confusing is that if there are already applied patches, the
> > diff shown is the one of the previous top patch
> 
> Are you sure it doesn't only show the local changes (which you might
> want to add in a new patch)?

I confirm this bug.

> I think we should put some default patch description.

I agree.  Sometimes it's too early to write a description.

-- 
Regards,
Pavel Roskin