Re: Some ideas for StGIT

From: Yann Dirson <ydirson@altern.org>
Date: Aug 3, 2007, 23:23 UTC
Message-ID: <20070803232351.GC30277@nan92-1-81-57-214-146.fbx.proxad.net>
In-Reply-To: <1186163410.26110.55.camel@dv>

On Fri, Aug 03, 2007 at 01:50:10PM -0400, Pavel Roskin wrote:

> One is to have a command opposite to "export".  It would read the files
> that "export" produces, replacing the existing patches.

This should be already possible (although I never used it), with "stg pop -a && stg import --replace ..."

> Another approach would be to reexamine the patch after "stg refresh -es"
> and to apply it instead of the original patch.  If the patch doesn't
> apply, the options would be to discard the edits or to re-launch the
> editor.

Added to wishes: https://gna.org/bugs/index.php?9674

Show 14 quoted lines

> Next issue is that it should be possible to create a patch in one
> operation.  StGIT follows quilt too closely here in requiring "new" and
> "refresh", instead of utilizing the advantage of the workflow that
> allows immediate editing of the sources without any commands.
> 
> Basically, I want one command that:
> 
> 1) shows user what was changed
> 2) allows user to name the patch
> 3) allows user to describe the patch
> 4) allows user to exclude files from the patch
> 5) doesn't require another command to put the changes to the patch
> 
> I think the most natural approach would be to enhance "stg new".

Sure, something like this could be done. A syntax like the following would IMHO fit in how things are done, but does not exactly address 4:

$ stg new <name> -m <msg> -s [--] <files> <to> <add>

Maybe another --exclude flag to reverse the meaning of the listed files would be a solution, but I'm not thrilled by this idea...

Show 5 quoted lines

>  I see
> "stg new -s" is supposed to show the changes, but it's currently broken.
> This is run in a clean StGIT repository with no patches:
> 
> $ stg new -s foo

Hm, I'm not sure what -s would be supposed to show here, since we're asking for the creation of a patch, which currently always starts empty.

Especially confusing is that if there are already applied patches, the diff shown is the one of the previous top patch - and if there is no applied patches, we get the exception you noticed.

I guess -s should be removed for 0.13.1.

> Another backtrace in "stg new", also run in a clean StGIT repository with no patches:

This appears to occur when there is no description file, or when it is empty. Thanks for the report.

I also tried with "stg refresh -m ''" to see if it caused the same problem, but it appears to have another problem instead: it does not refresh the patch description at all.

My guess is that we should not allow empty patch description (and maybe fill it with provided patchname). What did you want to acheieve precisely with that command ?

> Finally, it would be great to have TLS support in the mail command.
> Mercurial has it, and looking at their mail.py, it doesn't seem to be
> much work.

Added to wishes: https://gna.org/bugs/index.php?9673

Thanks,

-- 
Yann