Re: [PATCH] Allow hand-editing of patches before sending

From: Catalin Marinas <catalin.marinas@gmail.com>
Date: Nov 3, 2006, 12:44 UTC
Message-ID: <b0943d9e0611030444w13e04586u185413c2562d45bc@mail.gmail.com>
In-Reply-To: <20061103095859.GC16721@diana.vm.bytemark.co.uk>

On 03/11/06, Karl Hasselström <kha@treskal.com> wrote:

> I believe all the mails I send with mutt are QP-encoded, and they
> don't look funny, do they? (You'd see the separator just above my
> signature as "--=20" if that was the case; it has a trailing
> whitespace.)

This e-mail, in gmail:

Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit

In Gnus (via gmane, no "=20" displayed though Gnus can handle this encoding correctly):

Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: QUOTED-PRINTABLE

It looks like the mail server re-encodes the message.

Show 7 quoted lines

> > However, I'd like the message body to still be 8bit and the QP
> > encoding optional (either command line option or [stgit] config
> > variable).
>
> Are you sure? Wouldn't it be better to teach StGIT to eat QP-encoded
> mails, and use 7bit encoding when the patch is all ascii? (And still
> have an option to force 8bit instead of QP if desired, of course.)

Well, I don't have any strong opinion here, as long as QP is more widely available. My impression with Gnus was that it cannot handle but I think there was an encoding problem.

The initial mail command implementation was inspired from sendpatchset but we should probably now use the email Python package and let it handle the encoding and decoding (for import).