Re: [PATCH] Allow hand-editing of patches before sending

From: Karl Hasselström <kha@treskal.com>
Date: Nov 3, 2006, 13:02 UTC
Message-ID: <20061103130259.GA20611@diana.vm.bytemark.co.uk>
In-Reply-To: <b0943d9e0611030444w13e04586u185413c2562d45bc@mail.gmail.com>

On 2006-11-03 12:44:48 +0000, Catalin Marinas wrote:

Show 10 quoted lines

> On 03/11/06, Karl Hasselström <kha@treskal.com> wrote:
>
> > Are you sure? Wouldn't it be better to teach StGIT to eat
> > QP-encoded mails, and use 7bit encoding when the patch is all
> > ascii? (And still have an option to force 8bit instead of QP if
> > desired, of course.)
>
> Well, I don't have any strong opinion here, as long as QP is more
> widely available. My impression with Gnus was that it cannot handle
> but I think there was an encoding problem.

Most probably, yes. Not supporting QP would count as a serious deficiency in an e-mail client.

> The initial mail command implementation was inspired from
> sendpatchset but we should probably now use the email Python package
> and let it handle the encoding and decoding (for import).

Or try to use the git plumbing directly, if reasonable. Mail encoding and decoding isn't my idea of fun -- I just want it to not break. And I don't see much point in StGIT replicating core GIT functionality when there's no reason to.

-- 
Karl Hasselström, kha@treskal.com