git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 0/3] bundle-uri: do not die on unresolvable relative URIs

From
Patrick Steinhardt <ps@pks.im>
Date
Nov 9, 2026, 09:26 UTC
Message-ID
<avGR422rPHr1Orv5@pks.im>
In-Reply-To
<20261106172533.612673-1-aniketgupta3001@gmail.com>
On Fri, Nov 06, 2026 at 05:25:33PM +0000, Aniket Gupta wrote:
Show 5 quoted lines
> Hi Stolee,
> 
> Thanks for the review.
> 
> > I'm less convinced on this factor.

Huh, where does this quote come from? It's certainly not part of the mail you reply to. Also, you stripped all necessary context for somebody to know what this was even talking about.

Show 6 quoted lines
> Fair point. I tried it with a password in the remote URL but the "failed
> to download bundle from URI" warning prints it as is. I think this patch
> will only cover this one message. The reason I did it is that git
> already hides the password when it shows a remote URL. For eg. in the
> "From" line of fetch. It is a separate patch so it is easy to drop if
> you and Patrick think it is not worth it.

I don't have a strong opinion on whether or not we should strip credentials. It feels like the right thing to do, but I trust Stolee's input here.

But the other part of patch 2 should definitely be retained in my opinion, because printing an error with the URL after we have trimmed "../" components off of it is just plain not useful. There is no way for the user to tell how the URL is broken because we may have already stripped the relevant components here.

Patrick
Previous: Aniket GuptaNext: Aniket Gupta
Message 12 of 13 in “bundle-uri: do not die on unresolvable relative URIs”
  1. 0/3 bundle-uri: do not die on unresolvable relative URIsAniket Gupta, Nov 5, 2026
  2. 1/3 remote: add relative_url_gently()Aniket Gupta, Nov 5, 2026
  3. Derrick StoleeNov 6, 2026
  4. 2/3 remote: do not show credentials when relative_url() failsAniket Gupta, Nov 5, 2026
  5. Derrick StoleeNov 6, 2026
  6. Junio C HamanoNov 6, 2026
  7. Aniket GuptaNov 9, 2026
  8. 3/3 bundle-uri: do not die on unresolvable relative URIsAniket Gupta, Nov 5, 2026
  9. Derrick StoleeNov 6, 2026
  10. Derrick StoleeNov 6, 2026
  11. Aniket GuptaNov 6, 2026
  12. Patrick SteinhardtNov 9, 2026
  13. Aniket GuptaNov 9, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.