Re: [PATCH v3 0/3] bundle-uri: do not die on unresolvable relative URIs
- From
Derrick Stolee <stolee@gmail.com>
- Date
- Nov 6, 2026, 14:57 UTC
- Message-ID
- <25a32212-4906-467b-9b1b-301b38ca0e2d@gmail.com>
- In-Reply-To
- <20261105152842.566318-1-aniketgupta3001@gmail.com>
On 11/5/2026 10:28 AM, Aniket Gupta wrote:
> A bundle list can contain a relative URI that cannot be resolved, and > today one such entry makes the whole clone die. This series lets the > bundle code report it and skip that bundle instead.
When reading patch-by-patch, I initially was concerned about the behavior change. However, patch 3 removes a long-standing TODO comment _that I wrote_ so I'm inclined to take the change. I didn't see anything critical to change about these patches.
That said, we may have something for #leftoverbits:
How could we create a toggle to re-enable the die() if desired?
Perhaps a user _wants_ to fail on bad URIs instead of spending time on an incomplete bundle advertisement and expensive fetch from the remote.
Such an option could be a follow-up, now that you've implemented the _gently() version and the bundle URI machinery could decide for itself whether this is a hard failure or not.
Thanks, -Stolee