git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 2/3] remote: do not show credentials when relative_url() fails

From
AGAniket Gupta <aniketgupta3001@gmail.com>
Date
Nov 9, 2026, 10:39 UTC
Message-ID
<20261109103916.397673-1-aniketgupta3001@gmail.com>
In-Reply-To
<85924f20-298f-401e-88f7-7fb3f949d0fe@gmail.com>
> I'm less convinced on this factor. I understand anonymizing the URL if
> we are sending it to a location that is perhaps "less trusted" (like
> trace logs) but the user asked us to operate on a given URL that caused
> problems, so they should know the string that caused problems.
I answered this on the cover letter by mistake. Here it is again. Apologies for the spam.

Fair point. I tried it with a password in the remote URL but the "failed to download bundle from URI" warning prints it as is. I think this patch will only cover this one message. The reason I did it is that git already hides the password when it shows a remote URL. For eg. in the "From" line of fetch. It is a separate patch so it is easy to drop if you and Patrick think it is not worth it.

Previous: Junio C HamanoNext: Aniket Gupta
Message 7 of 13 in “bundle-uri: do not die on unresolvable relative URIs”
  1. 0/3 bundle-uri: do not die on unresolvable relative URIsAniket Gupta, Nov 5, 2026
  2. 1/3 remote: add relative_url_gently()Aniket Gupta, Nov 5, 2026
  3. Derrick StoleeNov 6, 2026
  4. 2/3 remote: do not show credentials when relative_url() failsAniket Gupta, Nov 5, 2026
  5. Derrick StoleeNov 6, 2026
  6. Junio C HamanoNov 6, 2026
  7. Aniket GuptaNov 9, 2026
  8. 3/3 bundle-uri: do not die on unresolvable relative URIsAniket Gupta, Nov 5, 2026
  9. Derrick StoleeNov 6, 2026
  10. Derrick StoleeNov 6, 2026
  11. Aniket GuptaNov 6, 2026
  12. Patrick SteinhardtNov 9, 2026
  13. Aniket GuptaNov 9, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.