Re: [PATCH v3 2/3] remote: do not show credentials when relative_url() fails
- From
- Aniket Gupta <aniketgupta3001@gmail.com>
- Date
- Nov 9, 2026, 10:39 UTC
- Message-ID
- <20261109103916.397673-1-aniketgupta3001@gmail.com>
- In-Reply-To
- <85924f20-298f-401e-88f7-7fb3f949d0fe@gmail.com>
> I'm less convinced on this factor. I understand anonymizing the URL if > we are sending it to a location that is perhaps "less trusted" (like > trace logs) but the user asked us to operate on a given URL that caused > problems, so they should know the string that caused problems.
I answered this on the cover letter by mistake. Here it is again. Apologies for the spam.
Fair point. I tried it with a password in the remote URL but the "failed to download bundle from URI" warning prints it as is. I think this patch will only cover this one message. The reason I did it is that git already hides the password when it shows a remote URL. For eg. in the "From" line of fetch. It is a separate patch so it is easy to drop if you and Patrick think it is not worth it.