git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 0/2] commit: allow -m/-F/-c/-C for all --fixup variations

From
ECErik Cervin-Edin <erik@cervined.in>
Date
Nov 5, 2026, 14:51 UTC
Message-ID
<auyXU7spezFBYohU@mbp>
In-Reply-To
<ba174a25-f7bc-4a5d-918c-87229b2fb5f6@gmail.com>
On 26/10/21 04:13PM, Phillip Wood wrote:
> Hi Erik
> 
> Sorry it has taken me so long to get round to commenting on these patches
Thank you for reviewing it :)
Sorry for the slow reply.
> think that supporting -m and -F with --fixup is useful and I cannot see a
> reason not to support -C as well. I've left a couple of comments, but the
> only thing I'm really worried about is calling test_set_editor() outside of
> a subshell in the second patch.

I glanced over your review and from the looks of it, it makes sense -- I just haven't had the time to reroll a V4 yet. But I plan to!

- Erik
Previous: Phillip WoodNext: Phillip Wood
Message 17 of 18 in “commit: allow -m/-F with --fixup=amend: or reword:”
  1. 0/1 commit: allow -m/-F with --fixup=amend: or reword:erik@cervined.in, May 18, 2026
  2. 1/1 commit: allow -m/-F with --fixup=amend: or reword:erik@cervined.in, May 18, 2026
  3. Junio C HamanoMay 18, 2026
  4. Phillip WoodMay 18, 2026
  5. Erik Cervin EdinMay 24, 2026
  6. 0/2 commit: allow -m/-F/-c/-C for all --fixup variationserik@cervined.in, May 26, 2026
  7. 1/2 commit: allow -m/-F for all kinds of --fixuperik@cervined.in, May 26, 2026
  8. 2/2 commit: allow -c/-C for all kinds of --fixuperik@cervined.in, May 26, 2026
  9. Junio C HamanoAug 26, 2026
  10. Erik Cervin EdinSep 4, 2026
  11. 0/2 commit: allow -m/-F/-c/-C for all --fixup variationserik@cervined.in, Sep 22, 2026
  12. 1/2 commit: allow -m/-F for all kinds of --fixuperik@cervined.in, Sep 22, 2026
  13. Phillip WoodOct 21, 2026
  14. 2/2 commit: allow -c/-C for all kinds of --fixuperik@cervined.in, Sep 22, 2026
  15. Phillip WoodOct 21, 2026
  16. Phillip WoodOct 21, 2026
  17. Erik Cervin-EdinNov 5, 2026
  18. Phillip WoodNov 9, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.