Re: [PATCH v3 0/2] commit: allow -m/-F/-c/-C for all --fixup variations
- From
- Erik Cervin-Edin <erik@cervined.in>
- Date
- Nov 5, 2026, 14:51 UTC
- Message-ID
- <auyXU7spezFBYohU@mbp>
- In-Reply-To
- <ba174a25-f7bc-4a5d-918c-87229b2fb5f6@gmail.com>
On 26/10/21 04:13PM, Phillip Wood wrote:
> Hi Erik > > Sorry it has taken me so long to get round to commenting on these patches
Thank you for reviewing it :)
Sorry for the slow reply.
> think that supporting -m and -F with --fixup is useful and I cannot see a > reason not to support -C as well. I've left a couple of comments, but the > only thing I'm really worried about is calling test_set_editor() outside of > a subshell in the second patch.
I glanced over your review and from the looks of it, it makes sense -- I just haven't had the time to reroll a V4 yet. But I plan to!
- Erik