From: Erik Cervin-Edin Date: Thu, 05 Nov 2026 14:51:52 GMT Subject: Re: [PATCH v3 0/2] commit: allow -m/-F/-c/-C for all --fixup variations Message-ID: In-Reply-To: On 26/10/21 04:13PM, Phillip Wood wrote: > Hi Erik > > Sorry it has taken me so long to get round to commenting on these patches Thank you for reviewing it :) Sorry for the slow reply. > think that supporting -m and -F with --fixup is useful and I cannot see a > reason not to support -C as well. I've left a couple of comments, but the > only thing I'm really worried about is calling test_set_editor() outside of > a subshell in the second patch. I glanced over your review and from the looks of it, it makes sense -- I just haven't had the time to reroll a V4 yet. But I plan to! - Erik