Re: [PATCH v2 2/4] loose: lift loose object index parsing logic into helper

From: Justin Tobler <jltobler@gmail.com>
Date: Oct 29, 2026, 21:10 UTC
Message-ID: <auO2H-RBiRB_vwVl@denethor>
In-Reply-To: <auL-W9Z2H9Ivn1RC@pks.im>

On 26/10/29 09:05AM, Patrick Steinhardt wrote:

Show 9 quoted lines

> On Wed, Oct 28, 2026 at 07:24:11PM -0500, Justin Tobler wrote:
> > -	if (inserted)
> > -		oidtree_insert(loose->cache, compat_oid, NULL);
> > +	if (inserted && cache)
> > +		oidtree_insert(cache, compat_oid, NULL);
> 
> Okay, so the `cache` is optional now. You mention that fact in the
> commit message, but you don't explain why that is. I assume a subsequent
> commit will make use of this.

Yes, this is used in the final patch. I'll update the commit message to make this a bit more clear.

-Justin

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.