From: Justin Tobler <jltobler@gmail.com>
Date: Thu, 29 Oct 2026 21:10:48 GMT
Subject: Re: [PATCH v2 2/4] loose: lift loose object index parsing logic into helper
Message-ID: <auO2H-RBiRB_vwVl@denethor>
In-Reply-To: <auL-W9Z2H9Ivn1RC@pks.im>

On 26/10/29 09:05AM, Patrick Steinhardt wrote:
> On Wed, Oct 28, 2026 at 07:24:11PM -0500, Justin Tobler wrote:
> > -	if (inserted)
> > -		oidtree_insert(loose->cache, compat_oid, NULL);
> > +	if (inserted && cache)
> > +		oidtree_insert(cache, compat_oid, NULL);
> 
> Okay, so the `cache` is optional now. You mention that fact in the
> commit message, but you don't explain why that is. I assume a subsequent
> commit will make use of this.

Yes, this is used in the final patch. I'll update the commit message to
make this a bit more clear.

-Justin