Re: [PATCH v4 3/4] object-file: explicitly write ".keep" lockfile
- From
Justin Tobler <jltobler@gmail.com>
- Date
- Oct 27, 2026, 18:26 UTC
- Message-ID
- <auDsoWt5XVXw2hPN@denethor>
- In-Reply-To
- <CAOLa=ZSdT2W19-Vg682iv6zhq6sEFM0+rHS-NqL=XQu--JOknw@mail.gmail.com>
On 26/10/26 09:08AM, Karthik Nayak wrote:
Show 7 quoted lines
> Justin Tobler <jltobler@gmail.com> writes:
> > + if (write_in_full(fd, contents.buf, contents.len) < 0) {
> > + ret = error_errno(_("unable to write '%s'"), lock_path.buf);
> > + close(fd);
> > + unlink(lock_path.buf);
>
> Should we use `unlink_or_warn()` here?Ya, adding a warning here would probably be useful. I'll go ahead and do so in the next version.
Thanks, -Justin