Re: [PATCH v4 3/4] object-file: explicitly write ".keep" lockfile
- From
Justin Tobler <jltobler@gmail.com>
- Date
- Oct 27, 2026, 18:32 UTC
- Message-ID
- <auDt1rq4a_ENlQiK@denethor>
- In-Reply-To
- <auDsoWt5XVXw2hPN@denethor>
On 26/10/27 01:26PM, Justin Tobler wrote:
Show 11 quoted lines
> On 26/10/26 09:08AM, Karthik Nayak wrote:
> > Justin Tobler <jltobler@gmail.com> writes:
> > > + if (write_in_full(fd, contents.buf, contents.len) < 0) {
> > > + ret = error_errno(_("unable to write '%s'"), lock_path.buf);
> > > + close(fd);
> > > + unlink(lock_path.buf);
> >
> > Should we use `unlink_or_warn()` here?
>
> Ya, adding a warning here would probably be useful. I'll go ahead and do
> so in the next version.I just noticed that this series was already merged to next, so I can just send this change a separate patch.
-Justin