From: Justin Tobler Date: Tue, 27 Oct 2026 18:26:27 GMT Subject: Re: [PATCH v4 3/4] object-file: explicitly write ".keep" lockfile Message-ID: In-Reply-To: On 26/10/26 09:08AM, Karthik Nayak wrote: > Justin Tobler writes: > > + if (write_in_full(fd, contents.buf, contents.len) < 0) { > > + ret = error_errno(_("unable to write '%s'"), lock_path.buf); > > + close(fd); > > + unlink(lock_path.buf); > > Should we use `unlink_or_warn()` here? Ya, adding a warning here would probably be useful. I'll go ahead and do so in the next version. Thanks, -Justin