git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [Outreachy PATCH] diffcore-rename: stop using the_repository

From
Patrick Steinhardt <ps@pks.im>
Date
Oct 26, 2026, 10:52 UTC
Message-ID
<at8w9u6qA1dhmw3r@pks.im>
In-Reply-To
<20261024221341.92086-1-okhuomonajayi54@gmail.com>
On Sat, Oct 24, 2026 at 11:13:41PM +0100, Okhuomon Ajayi wrote:
Show 5 quoted lines
> diffcore_rename_extended() already has the repository through
> options. Use its hash algorithm when checking for empty blobs,
> and pass it to start_delayed_progress().
> 
> Remove the USE_THE_REPOSITORY_VARIABLE definition.

All of the conversions are trivial, and we already dereference `options->repo` unconditionally in this function. So the patch looks trivially correct to me, nice!

Patrick
Previous: Okhuomon AjayiNext: Okhuomon Ajayi
Message 2 of 5 in “diffcore-rename: stop using the_repository”
  1. diffcore-rename: stop using the_repositoryOkhuomon Ajayi, Oct 24, 2026
  2. Patrick SteinhardtOct 26, 2026
  3. Okhuomon AjayiOct 26, 2026
  4. Patrick SteinhardtOct 26, 2026
  5. Okhuomon AjayiOct 26, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.