Re: [Outreachy PATCH] diffcore-rename: stop using the_repository
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Oct 26, 2026, 10:52 UTC
- Message-ID
- <at8w9u6qA1dhmw3r@pks.im>
- In-Reply-To
- <20261024221341.92086-1-okhuomonajayi54@gmail.com>
On Sat, Oct 24, 2026 at 11:13:41PM +0100, Okhuomon Ajayi wrote:
Show 5 quoted lines
> diffcore_rename_extended() already has the repository through > options. Use its hash algorithm when checking for empty blobs, > and pass it to start_delayed_progress(). > > Remove the USE_THE_REPOSITORY_VARIABLE definition.
All of the conversions are trivial, and we already dereference `options->repo` unconditionally in this function. So the patch looks trivially correct to me, nice!
Patrick