Re: [Outreachy PATCH] diffcore-rename: stop using the_repository
Thanks for the review, Patrick!
On Mon, Oct 26, 2026 at 11:52 AM Patrick Steinhardt <ps@pks.im> wrote:
Show 13 quoted lines
>
> On Sat, Oct 24, 2026 at 11:13:41PM +0100, Okhuomon Ajayi wrote:
> > diffcore_rename_extended() already has the repository through
> > options. Use its hash algorithm when checking for empty blobs,
> > and pass it to start_delayed_progress().
> >
> > Remove the USE_THE_REPOSITORY_VARIABLE definition.
>
> All of the conversions are trivial, and we already dereference
> `options->repo` unconditionally in this function. So the patch looks
> trivially correct to me, nice!
>
> Patrick