Re: [Outreachy PATCH] diffcore-rename: stop using the_repository
On Mon, Oct 26, 2026 at 12:22:59PM +0100, Okhuomon Ajayi wrote:
> Thanks for the review, Patrick!
Nit: please don't top-post, the expectation is to write your answer
below the parts you respond to. Thanks!
Patrick
Show 14 quoted lines
> On Mon, Oct 26, 2026 at 11:52 AM Patrick Steinhardt <ps@pks.im> wrote:
> >
> > On Sat, Oct 24, 2026 at 11:13:41PM +0100, Okhuomon Ajayi wrote:
> > > diffcore_rename_extended() already has the repository through
> > > options. Use its hash algorithm when checking for empty blobs,
> > > and pass it to start_delayed_progress().
> > >
> > > Remove the USE_THE_REPOSITORY_VARIABLE definition.
> >
> > All of the conversions are trivial, and we already dereference
> > `options->repo` unconditionally in this function. So the patch looks
> > trivially correct to me, nice!
> >
> > Patrick