Re: [PATCH v2 3/3] t/README: document writing concurrency-safe helpers
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Aug 10, 2026, 06:06 UTC
- Message-ID
- <anlqeshH0FXaLvF5@pks.im>
- In-Reply-To
- <CAC2Qwm+Jni+xU=gaef1AWCMj9+GUQhMrCWX9DFpS3y757pxv=Q@mail.gmail.com>
On Fri, Aug 07, 2026 at 09:51:34AM -0700, Michael Montalbo wrote:
Show 23 quoted lines
> On Tue, Aug 4, 2026 at 1:03 AM Patrick Steinhardt <ps@pks.im> wrote: > > > > > > > > +Writing concurrency-safe helpers > > > +-------------------------------- > > > > Nit: this paragraph is quite specific to lib-httpd, so it would make > > sense to mention it in the header here. E.g. > > > > Writing concurrency-safe lib-httpd helpers > > > > Originally, I did just have this as a blurb in t/lib-httpd.sh. I ended up moving > it here and trying to make the advice apply more generally, though the only > other existing example I could find in another domain was the > make_symlink() reference. My intention was to make sure someone working > on a test helper with concurrency didn't skip over the section just because > they saw "http" and thought the advice didn't apply to their use case. > > I'm inclined to make the language in the section more http-agnostic rather > than changing the title to be specific to http, but I do not feel very strongly > about it. If we were to frame this as http-specific advice maybe it should go > back to t/lib-httpd.sh instead of t/README?
Dunno. I'm not sure there's much value outside of httpd, so I'm still inclined to make it httpd-specific. And if so, moving it into "t/" would make sense.
But I don't feel overly strong about this, either, so I won't complain if this section stays as-is.
Patrick