Re: [PATCH v3 2/3] t/lib-httpd: make http-429 first-request check atomic
- From
Michael Montalbo <mmontalbo@gmail.com>
- Date
- Aug 31, 2026, 17:09 UTC
- Message-ID
- <CAC2Qwm+L01XZgys2NGtZwWfVapWmnqDbsevt3Z4WKpS9EoP65A@mail.gmail.com>
- In-Reply-To
- <apUqs8N3EnTFngyQ@pks.im>
On Mon, Aug 31, 2026 at 12:18 AM Patrick Steinhardt <ps@pks.im> wrote:
Show 8 quoted lines
> > On Thu, Aug 13, 2026 at 01:05:35AM +0000, Michael Montalbo via GitGitGadget wrote: > > From: Michael Montalbo <mmontalbo@gmail.com> > > > > http-429.sh returns 429 to the first request for an endpoint and > > forwards later ones to git-http-backend so the retry succeeds. It > > remembers that it has already answered 429 by checking for a shared > > state file with "test -f" and creating it with "touch".
...
Show 8 quoted lines
> > There is no regression test. The check and the set are adjacent commands > > with nothing in between to synchronize on, so the overlap cannot be > > forced deterministically, only reproduced by chance; the fix is > > preventive. > > A lot of AI-fluff in this message that could have otherwise been much > briefer, but okay. >
You are right. I will go through all the prose in the series and re-write it by hand. I apologize for giving you unnecessary AI-fluff to read and will not do it again.