git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 2/3] t/lib-httpd: make http-429 first-request check atomic

From
Michael Montalbo <mmontalbo@gmail.com>
Date
Aug 31, 2026, 17:31 UTC
Message-ID
<CAC2QwmJ2AgU0y77tmRhs=Ycx-CuWEzzfKsVMn98Wa1EUvHHsKw@mail.gmail.com>
In-Reply-To
<xmqq33vuz6lo.fsf@gitster.g>
On Mon, Aug 31, 2026 at 7:51 AM Junio C Hamano <gitster@pobox.com> wrote:
Show 5 quoted lines
>
> I too find it disturbing it that the messages from this author tends
> to contain material that triggers "it may not be wrong, but is it
> relevant?" reactions.  More does not mean better.
>

Thank you for this feedback. I agree with it and will avoid relying on AI as I have to create and edit prose for documentation and cover letters.

Show 22 quoted lines
> The above made me curious enough to ask a near-by Gemini to distill
> it down to quarter of the original length without losing essense of
> the original.
>
>     http-429.sh marks that a 429 response was served by creating a
>     state file with "test -f" and "touch".  This check-and-set
>     sequence is not atomic and can race under concurrent Apache
>     requests, causing multiple requests to claim first-arrival
>     status.
>
>     Replace the check and "touch" with an atomic "mkdir", which
>     fails if the directory already exists.  In "permanent" mode,
>     skip the "mkdir" entirely so no state marker is ever created.
>
>     Omit a regression test, as this concurrency window cannot be
>     forced deterministically without artificial synchronization
>     points.
>
> This seems readable enough to me, but may still need some manual
> clean-up, but this experiment told me that "A lot of AI-fluff" is
> not something users cannot avoid without some extra work.
>

I agree, even though I have spent a lot of time trying to "copy-edit" what is generated, the end result does tend to be verbose and include unnecessary detail. Compared to what I start with based on my initial idea and generated rough draft, a lot has been edited away. However, I do think I have regretfully avoided doing some of that extra work. Apologies for having you all read unnecessary AI-fluff, I will write prose for documentation and similar from scratch.

Previous: Junio C HamanoNext: Michael Montalbo
Message 27 of 43 in “t/lib-httpd: make CGI test helpers concurrency-safe”
  1. 0/3 t/lib-httpd: make CGI test helpers concurrency-safeMichael Montalbo via GitGitGadget, Jul 8, 2026
  2. 1/3 t/lib-httpd: fix apply-one-time-script race under concurrent requestsMichael Montalbo via GitGitGadget, Jul 8, 2026
  3. Junio C HamanoJul 8, 2026
  4. Michael MontalboJul 9, 2026
  5. 2/3 t/lib-httpd: make http-429 first-request check atomicMichael Montalbo via GitGitGadget, Jul 8, 2026
  6. Junio C HamanoJul 8, 2026
  7. Junio C HamanoJul 8, 2026
  8. Michael MontalboJul 9, 2026
  9. 3/3 t/README: document writing concurrency-safe helpersMichael Montalbo via GitGitGadget, Jul 8, 2026
  10. Junio C HamanoJul 8, 2026
  11. 0/3 t/lib-httpd: make CGI test helpers concurrency-safeMichael Montalbo via GitGitGadget, Jul 10, 2026
  12. 1/3 t/lib-httpd: fix apply-one-time-script race under concurrent requestsMichael Montalbo via GitGitGadget, Jul 10, 2026
  13. Patrick SteinhardtAug 4, 2026
  14. Michael MontalboAug 7, 2026
  15. 2/3 t/lib-httpd: make http-429 first-request check atomicMichael Montalbo via GitGitGadget, Jul 10, 2026
  16. 3/3 t/README: document writing concurrency-safe helpersMichael Montalbo via GitGitGadget, Jul 10, 2026
  17. Patrick SteinhardtAug 4, 2026
  18. Michael MontalboAug 7, 2026
  19. Patrick SteinhardtAug 10, 2026
  20. Michael MontalboAug 2, 2026
  21. Junio C HamanoAug 3, 2026
  22. 0/3 t/lib-httpd: make CGI test helpers concurrency-safeMichael Montalbo via GitGitGadget, Aug 13, 2026
  23. 1/3 t/lib-httpd: fix apply-one-time-script race under concurrent requestsMichael Montalbo via GitGitGadget, Aug 13, 2026
  24. 2/3 t/lib-httpd: make http-429 first-request check atomicMichael Montalbo via GitGitGadget, Aug 13, 2026
  25. Patrick SteinhardtAug 31, 2026
  26. Junio C HamanoAug 31, 2026
  27. Michael MontalboAug 31, 2026
  28. Michael MontalboAug 31, 2026
  29. 3/3 t/lib-httpd: document writing concurrency-safe CGI helpersMichael Montalbo via GitGitGadget, Aug 13, 2026
  30. Patrick SteinhardtAug 31, 2026
  31. Junio C HamanoAug 26, 2026
  32. Patrick SteinhardtAug 31, 2026
  33. 0/3 t/lib-httpd: make CGI test helpers concurrency-safeMichael Montalbo via GitGitGadget, Sep 1, 2026
  34. 1/3 t/lib-httpd: fix apply-one-time-script race under concurrent requestsMichael Montalbo via GitGitGadget, Sep 1, 2026
  35. 2/3 t/lib-httpd: make http-429 first-request check atomicMichael Montalbo via GitGitGadget, Sep 1, 2026
  36. 3/3 t/lib-httpd: document writing concurrency-safe CGI helpersMichael Montalbo via GitGitGadget, Sep 1, 2026
  37. Patrick SteinhardtSep 1, 2026
  38. Michael MontalboSep 1, 2026
  39. 0/3 t/lib-httpd: make CGI test helpers concurrency-safeMichael Montalbo via GitGitGadget, Sep 1, 2026
  40. 1/3 t/lib-httpd: fix apply-one-time-script race under concurrent requestsMichael Montalbo via GitGitGadget, Sep 1, 2026
  41. 2/3 t/lib-httpd: make http-429 first-request check atomicMichael Montalbo via GitGitGadget, Sep 1, 2026
  42. 3/3 t/lib-httpd: document writing concurrency-safe CGI helpersMichael Montalbo via GitGitGadget, Sep 1, 2026
  43. Patrick SteinhardtSep 3, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.