Re: [PATCH] t9001: set TERM=dumb to prevent ANSI output

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 7, 2008, 11:41 UTC
Message-ID: <alpine.LSU.1.00.0803071240590.19395@racer.site>
In-Reply-To: <7vskz33vow.fsf@gitster.siamese.dyndns.org>

Hi,

On Thu, 6 Mar 2008, Junio C Hamano wrote:

Show 17 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
> 
> > Christian Couder <chriscool@tuxfamily.org> writes:
> > ...
> >> This may not work well with colored output.
> >> In test-lib.sh line 62 there is :
> >>
> >> [ "x$TERM" != "xdumb" ] &&
> >> 	[ -t 1 ] &&
> >> 	tput bold >/dev/null 2>&1 &&
> >> 	tput setaf 1 >/dev/null 2>&1 &&
> >> 	tput sgr0 >/dev/null 2>&1 &&
> >> 	color=t
> >
> > Ahh.  Sorry about that.
> 
> Ahem, third time lucky.

Well, with this:

>  t/test-lib.sh |   24 +++++++++++++++++-------

I think it is no longer worth it _not_ to special-case it. IOW I'd prefer my original patch for simplicity.

Ciao, Dscho