Re: [PATCH] t9001: set TERM=dumb to prevent ANSI output

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 6, 2008, 23:16 UTC
Message-ID: <7vmypb8muj.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <alpine.LSU.1.00.0803061752340.3941@racer.site>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> At least on one of my machines, Term::ReadLine tries to be clever and
> sends \x1b\x5b1034h at the end of the script when TERM is set to 'xterm'.
>
> To prevent that, force TERM=dumb just for the test.

We try to set up a pretty vanilla environment for test repeatability in t/test-lib.sh, and I suspect we would simply want to do this over there.

Wouldn't this make more sense?

diff --git a/t/test-lib.sh b/t/test-lib.sh
index 87a5ea4..7f6331a 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -7,8 +7,9 @@
 LANG=C
 LC_ALL=C
 PAGER=cat
+TERM=dumb
 TZ=UTC
-export LANG LC_ALL PAGER TZ
+export LANG LC_ALL PAGER TERM TZ
 EDITOR=:
 VISUAL=:
 unset GIT_EDITOR