Re: [PATCH] t9001: set TERM=dumb to prevent ANSI output
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 7, 2008, 17:40 UTC
- Message-ID
- <7vbq5q301l.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <alpine.LSU.1.00.0803071240590.19395@racer.site>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 28 quoted lines
> Hi, > > On Thu, 6 Mar 2008, Junio C Hamano wrote: > >> Junio C Hamano <gitster@pobox.com> writes: >> >> > Christian Couder <chriscool@tuxfamily.org> writes: >> > ... >> >> This may not work well with colored output. >> >> In test-lib.sh line 62 there is : >> >> >> >> [ "x$TERM" != "xdumb" ] && >> >> [ -t 1 ] && >> >> tput bold >/dev/null 2>&1 && >> >> tput setaf 1 >/dev/null 2>&1 && >> >> tput sgr0 >/dev/null 2>&1 && >> >> color=t >> > >> > Ahh. Sorry about that. >> >> Ahem, third time lucky. > > Well, with this: > >> t/test-lib.sh | 24 +++++++++++++++++------- > > I think it is no longer worth it _not_ to special-case it. IOW I'd prefer > my original patch for simplicity.
Hmm. Do you still prefer "patch individual" approach, even after considering longer term maintainability?