git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t9001: set TERM=dumb to prevent ANSI output

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 7, 2008, 17:40 UTC
Message-ID
<7vbq5q301l.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<alpine.LSU.1.00.0803071240590.19395@racer.site>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 28 quoted lines
> Hi,
>
> On Thu, 6 Mar 2008, Junio C Hamano wrote:
>
>> Junio C Hamano <gitster@pobox.com> writes:
>> 
>> > Christian Couder <chriscool@tuxfamily.org> writes:
>> > ...
>> >> This may not work well with colored output.
>> >> In test-lib.sh line 62 there is :
>> >>
>> >> [ "x$TERM" != "xdumb" ] &&
>> >> 	[ -t 1 ] &&
>> >> 	tput bold >/dev/null 2>&1 &&
>> >> 	tput setaf 1 >/dev/null 2>&1 &&
>> >> 	tput sgr0 >/dev/null 2>&1 &&
>> >> 	color=t
>> >
>> > Ahh.  Sorry about that.
>> 
>> Ahem, third time lucky.
>
> Well, with this:
>
>>  t/test-lib.sh |   24 +++++++++++++++++-------
>
> I think it is no longer worth it _not_ to special-case it.  IOW I'd prefer 
> my original patch for simplicity.

Hmm. Do you still prefer "patch individual" approach, even after considering longer term maintainability?

Previous: Johannes SchindelinNext: Johannes Schindelin
Message 8 of 9 in “t9001: set TERM=dumb to prevent ANSI output”
  1. t9001: set TERM=dumb to prevent ANSI outputJohannes Schindelin, Mar 6, 2008
  2. Junio C HamanoMar 6, 2008
  3. Johannes SchindelinMar 7, 2008
  4. Christian CouderMar 7, 2008
  5. Junio C HamanoMar 7, 2008
  6. Junio C HamanoMar 7, 2008
  7. Johannes SchindelinMar 7, 2008
  8. Junio C HamanoMar 7, 2008
  9. Johannes SchindelinMar 7, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.