Re: [PATCH] shortlog: take the first populated line of the description
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Mar 5, 2008, 14:48 UTC
- Message-ID
- <alpine.LSU.1.00.0803051544160.15786@racer.site>
- In-Reply-To
- <1204727050.0@pinky>
Hi,
On Wed, 5 Mar 2008, Andy Whitcroft wrote:
Show 19 quoted lines
> diff --git a/builtin-shortlog.c b/builtin-shortlog.c
> index af31aba..b22b0ed 100644
> --- a/builtin-shortlog.c
> +++ b/builtin-shortlog.c
> @@ -70,11 +70,12 @@ static void insert_one_record(struct shortlog *log,
> else
> free(buffer);
>
> + /* Skip any leading whitespace, including any blank lines. */
> + while (*oneline && isspace(*oneline))
> + oneline++;
> eol = strchr(oneline, '\n');
> if (!eol)
> eol = oneline + strlen(oneline);
> - while (*oneline && isspace(*oneline) && *oneline != '\n')
> - oneline++;
> if (!prefixcmp(oneline, "[PATCH")) {
> char *eob = strchr(oneline, ']');
> if (eob && (!eol || eob < eol))Why do you move the code around? Makes it harder to read your patch. Besides, you now strip empty lines at the beginning of the commit messages, right? Who produces such a thing?
Ciao, Dscho