Re: [PATCH] shortlog: take the first populated line of the description

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 5, 2008, 22:14 UTC
Message-ID: <7vmypclsy5.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <alpine.LFD.1.00.0803051638150.2947@xanadu.home>

Nicolas Pitre <nico@cam.org> writes:

Show 12 quoted lines

> On Wed, 5 Mar 2008, Junio C Hamano wrote:
>
>> I think Andy's fix to make the output side take away
>> unnecessary blank lines is unconditionally good.
>
> It is not "bad" in itself.  However that feels like papering over 
> another problem which IMHO has greater merits to be fixed.  We have 
> given special semantics to the first line of a commit log in many other 
> places now, so unless all those places are also made aware of 
> substandard commit logs too, I think it would be more productive to make 
> sure those logs are semi sensible upon entering Git in the first place 
> instead.

My understanding of the current status when I wrote that message was that everybody at commit.c layer (that is, everybody except shortlog) strips such garbage. Do you have a specific broken one in mind?

I suspect --pretty=format:%s might be broken; I didn't check.