[PATCH] shortlog: take the first populated line of the description
- From
Andy Whitcroft <apw@shadowen.org>
- Date
- Mar 5, 2008, 13:47 UTC
- Message-ID
- <1204727050.0@pinky>
Way back the perl version of shortlog would take the first populated line of the commit body. The builtin version mearly takes the first line. This leads to empty shortlog entries when there is some viable text in the commit.
Reinstate this behaviour igoring all lines with nothing but whitespace.
Signed-off-by: Andy Whitcroft <apw@shadowen.org> ---
This seems to be an improvement, returning to the original behaviour. I cannot think of any good reason not to take the first populated line for a shortlog. The alternative less agressive compromise might be to skip only completly empty lines at the start, but I am not sure that adds any value.
I seem to get a lot of these in converted SVN commits.
Comments?
-apw --- builtin-shortlog.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/builtin-shortlog.c b/builtin-shortlog.c index af31aba..b22b0ed 100644 --- a/builtin-shortlog.c +++ b/builtin-shortlog.c @@ -70,11 +70,12 @@ static void insert_one_record(struct shortlog *log, else free(buffer); + /* Skip any leading whitespace, including any blank lines. */ + while (*oneline && isspace(*oneline)) + oneline++; eol = strchr(oneline, '\n'); if (!eol) eol = oneline + strlen(oneline); - while (*oneline && isspace(*oneline) && *oneline != '\n') - oneline++; if (!prefixcmp(oneline, "[PATCH")) { char *eob = strchr(oneline, ']'); if (eob && (!eol || eob < eol))