Re: [PATCH] builtin clone: support bundles

From

Johannes Schindelin <johannes.schindelin@gmx.de>

Date

Mar 2, 2008, 17:34 UTC

Message-ID

<alpine.LSU.1.00.0803021731400.22527@racer.site>

In-Reply-To

<alpine.LNX.1.00.0803021128510.19665@iabervon.org>

Hi,

On Sun, 2 Mar 2008, Daniel Barkalow wrote:

> On Sun, 2 Mar 2008, Johannes Schindelin wrote:
> 
> > +	for (i = 0; i < ARRAY_SIZE(bundle_suffix); i++) {
> > +		const char *path;
> > +		path = mkpath("%s%s", repo, bundle_suffix[i]);
> > +		if (!stat(path, &st) && S_ISREG(st.st_mode)) {
> > +			*is_bundle = 1;
> > +			return xstrdup(make_absolute_path(path));
> 
> The problem I'm seeing in general is that origin/next's make_absolute_path 
> doesn't work on a regular file in the current directory. How are you 
> getting those tests to pass?

http://repo.or.cz/w/git/dscho.git?a=commitdiff;h=d066bd60e5a93d69c47318cf6e71f77c84b737e6

> In any case, I've got my current version at
> 
> git://iabervon.org/~barkalow/git.git builtin-clone

Thanks.

> The top patch is possibly the correct change for make_absolute_path(), 

Mine has a test now, too...

> and I've incorporated your changes (except that I'd reorganized a bunch 
> of stuff already, making some of them unnecessary and doing some of them 
> slightly differently). For example, I just make bundles not count as 
> local, and let transport.c deal with them in the normal path.

Makes sense.