Re: [PATCH] builtin clone: support bundles
- From
Daniel Barkalow <barkalow@iabervon.org>
- Date
- Mar 2, 2008, 16:48 UTC
- Message-ID
- <alpine.LNX.1.00.0803021128510.19665@iabervon.org>
- In-Reply-To
- <alpine.LSU.1.00.0803020743170.22527@racer.site>
On Sun, 2 Mar 2008, Johannes Schindelin wrote:
Show 6 quoted lines
> + for (i = 0; i < ARRAY_SIZE(bundle_suffix); i++) {
> + const char *path;
> + path = mkpath("%s%s", repo, bundle_suffix[i]);
> + if (!stat(path, &st) && S_ISREG(st.st_mode)) {
> + *is_bundle = 1;
> + return xstrdup(make_absolute_path(path));The problem I'm seeing in general is that origin/next's make_absolute_path doesn't work on a regular file in the current directory. How are you getting those tests to pass?
In any case, I've got my current version at
git://iabervon.org/~barkalow/git.git builtin-clone
The top patch is possibly the correct change for make_absolute_path(), and I've incorporated your changes (except that I'd reorganized a bunch of stuff already, making some of them unnecessary and doing some of them slightly differently). For example, I just make bundles not count as local, and let transport.c deal with them in the normal path.
-Daniel *This .sig left intentionally blank*