Re: [PATCH] Add test for cloning with "--reference" repo being a subset of source repo

From: Daniel Barkalow <barkalow@iabervon.org>
Date: Mar 3, 2008, 16:36 UTC
Message-ID: <alpine.LNX.1.00.0803031130090.19665@iabervon.org>
In-Reply-To: <200803031004.16568.johan@herland.net>

On Mon, 3 Mar 2008, Johan Herland wrote:

Show 24 quoted lines

> However, we should also test the case where the "--reference" repo is a
> _subset_ of the source repo (e.g. "git clone -l -s --reference A B C"),
> i.e. some objects are not available in the "--reference" repo, and will
> have to be found in the source repo.
> 
> However, this added test currently fails for me with the following output:
> 
> repo is /home/johan/git/git/t/trash/B/.git
> dir is E
> Initialize E/.git
> Initialized empty Git repository in E/.git/
> Okay
> Wrote /home/johan/git/git/t/trash/A/.git/objects
>  to E/.git/objects/info/alternates
> Wrote /home/johan/git/git/t/trash/B/.git/objects
>  to E/.git/objects/info/alternates
> Get for /home/johan/git/git/t/trash/B/.git
> error: Trying to write ref refs/remotes/origin/master with nonexistant object 276cf9e94287a7c4e6f79b2724460e9650fa4871
> fatal: Cannot update the ref 'refs/remotes/origin/master'.
> Remove junk E/.git
> Remove junk E
> 
> The same test work well with git-clone.sh.
> Not sure what's going on here, yet, but I thought I'd give you a heads up.

Thanks for the report; I haven't really gone through the local clone stuff, and I've altered the use of chdir at various points, so it's quite possible that it's not right at all for some cases.

	-Daniel
*This .sig left intentionally blank*