Re: [PATCH 0/5] Builtin "git remote"

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 2, 2008, 15:40 UTC
Message-ID: <alpine.LSU.1.00.0803021531230.22527@racer.site>
In-Reply-To: <alpine.LSU.1.00.0803021511420.22527@racer.site>

Hi,

On Sun, 2 Mar 2008, Johannes Schindelin wrote:

Show 13 quoted lines

> diff --git a/builtin-log.c b/builtin-log.c
> index bbadbc0..17e491b 100644
> --- a/builtin-log.c
> +++ b/builtin-log.c
> @@ -694,7 +694,7 @@ static void make_cover_letter(struct rev_info *rev, int use_stdout,
>  	if (!origin)
>  		return;
>  
> -	diff_setup(&opts);
> +	memcpy(&opts, &rev->diffopt, sizeof(opts));
>  	opts.output_format |= DIFF_FORMAT_SUMMARY | DIFF_FORMAT_DIFFSTAT;
>  
>  	diff_setup_done(&opts);

Ooops, I forgot to "make test"! And sure enough, t4013 breaks, because the "|=" was bogus to begin with.

Will resend, together with a patch to wrap the shortlog nicely.

... after "make test" ;-)

Ciao, Dscho

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.