Re: [PATCH 0/5] Builtin "git remote"
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Feb 29, 2008, 11:21 UTC
- Message-ID
- <alpine.LSU.1.00.0802291118540.22527@racer.site>
- In-Reply-To
- <alpine.LNX.1.00.0802282104500.19665@iabervon.org>
Hi,
On Thu, 28 Feb 2008, Daniel Barkalow wrote:
Show 14 quoted lines
> On Thu, 28 Feb 2008, Junio C Hamano wrote: > > > Johannes Schindelin <Johannes.Schindelin@gmx.de> writes: > > > > > It also demonstrates that format-patch --cover-letter should default to -M > > > for the diffstat (search for "git-remote.perl"...). > > > > It probably should inherit the settings for the primary part. > > You did generate the series with -M, especially [PATCH 4/5], > > didn't you? > > Obviously not the output_format, but everything else, I assume? Easy > enough to pass the main diff options into make_cover_letter() and use > them to initialize the diff options there.
Nice.
Show 14 quoted lines
> > > Johannes Schindelin (5): > > > path-list: add functions to work with unsorted lists > > > parseopt: add flag to stop on first non option > > > Test "git remote show" and "git remote prune" > > > Make git-remote a builtin > > > builtin-remote: prune remotes correctly that were added with --mirror > > > > Also I wish the default indentation were not that deep, and also > > line-wrapped at around 72-76 columns. > > Only for the cover letter, and not shortlog in general, I assume? It > should be easy to set the struct shortlog fields to whatever suits your > taste. Making it configurable (without getting tangled in other option > parsing) is trickier, though.
It is not really well documented, but with -w, you _can_ drive shortlog to do that. In the API, you have to set the members wrap_lines = 1, in1 = first_indent, in2 = indent, wrap = width in struct shortlog.
I suggest the values 4,8,76, respectively.
Ciao, Dscho