Re: [PATCH 0/5] Builtin "git remote"

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 29, 2008, 02:13 UTC
Message-ID: <alpine.LSU.1.00.0802290211460.22527@racer.site>
In-Reply-To: <7vwsoofrue.fsf@gitster.siamese.dyndns.org>

Hi,

On Thu, 28 Feb 2008, Junio C Hamano wrote:

Show 8 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > It also demonstrates that format-patch --cover-letter should default 
> > to -M for the diffstat (search for "git-remote.perl"...).
> 
> It probably should inherit the settings for the primary part.
> You did generate the series with -M, especially [PATCH 4/5],
> didn't you?

Yes, I did.

Show 9 quoted lines

> > Johannes Schindelin (5):
> >       path-list: add functions to work with unsorted lists
> >       parseopt: add flag to stop on first non option
> >       Test "git remote show" and "git remote prune"
> >       Make git-remote a builtin
> >       builtin-remote: prune remotes correctly that were added with --mirror
> 
> Also I wish the default indentation were not that deep, and also
> line-wrapped at around 72-76 columns.

Right.

I still have a few patches in my personal tree to implement "git-fmt", and I think that it should be easy to rework them into something usable for this purpose (4-character indent for the first line, 8-character for every subsequent one).

Also, it might be a good idea to teach "git log" to use these wrapping functions, as there are still regular contributors, even to Git itself, who seem to be unwilling to use <=76 characters/line.

Ciao, Dscho