Re: [PATCH] cvsexportcommit: be graceful when "cvs status" reorders the arguments

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 18, 2008, 16:27 UTC
Message-ID: <alpine.LSU.1.00.0802181624490.30505@racer.site>
In-Reply-To: <47B9A354.7070905@catalyst.net.nz>

Hi,

On Tue, 19 Feb 2008, Martin Langhoff wrote:

Show 7 quoted lines

> Junio C Hamano wrote:
> > A related naming guideline I failed to follow (because I was mostly 
> > copying your code) suggests that the hash here should be named 
> > %fullname, instead of %basename.  Then logically:
> 
> Double ACK on your logic and arguments - I was thinking "fullname" as I 
> read your first email.

Okay, will change.

> Not sure how stable the output is across CVS versions/ports WRT leading 
> slashes, might be a good idea to try to canonicalise the paths.

Note that for this reason, only the "File:" output -- which does not show slashes, but only the basenames -- is used to match the files. We need the full path in the git repository, though, to apply the patches.

> I am travelling at the moment, but I'll try and review the patch with 
> the actual code.

Thanks. I am confident that I will have posted another version by the time you come around to review it.

Ciao, Dscho