Re: [PATCH] cvsexportcommit: be graceful when "cvs status" reorders the arguments

From: Martin Langhoff <martin@catalyst.net.nz>
Date: Feb 18, 2008, 18:55 UTC
Message-ID: <47B9D484.1020304@catalyst.net.nz>
In-Reply-To: <7v1w7ap0vo.fsf@gitster.siamese.dyndns.org>

Junio C Hamano wrote:

Show 6 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
>>> The script uses File::Basename upfront so perhaps just simply...
>> I tried that.  But as the file need not exist, "basename" went on strike.
>>
>> So I'll keep the (ugly) version.

?! basename() never touches the disk. I just read it to confirm - $VERSION is 2.74 and I'm somewhat disappointed to find it's not as portable as I'd expect (perhaps it gets hardcoded during install?).

And my /usr/bin/basename doesn't care if the file exists either

  $ type basename
  basename is /usr/bin/basename
  $ basename /foo/bar/baz
  baz
  $ stat /foo/bar/baz
  stat: cannot stat `/foo/bar/baz': No such file or directory

So I am fairly confident that we can safely use File::Basename's basename() on arbitrary strings that look like a path. We use basename() quite a bit in our perl scripts in git.

cheers,

-- 
-----------------------------------------------------------------------
Martin @ Catalyst .Net .NZ  Ltd, PO Box 11-053, Manners St,  Wellington
WEB: http://catalyst.net.nz/           PHYS: Level 2, 150-154 Willis St
NZ: +64(4)916-7224    MOB: +64(21)364-017    UK: 0845 868 5733 ext 7224
      Make things as simple as possible, but no simpler - Einstein
-----------------------------------------------------------------------