Re: [PATCH] cvsexportcommit: be graceful when "cvs status" reorders the arguments

From: Martin Langhoff <martin@catalyst.net.nz>
Date: Feb 18, 2008, 15:25 UTC
Message-ID: <47B9A354.7070905@catalyst.net.nz>
In-Reply-To: <7vwsp3uf0u.fsf@gitster.siamese.dyndns.org>

Junio C Hamano wrote:

> A related naming guideline I failed to follow (because I was
> mostly copying your code) suggests that the hash here should be
> named %fullname, instead of %basename.  Then logically:

Double ACK on your logic and arguments - I was thinking "fullname" as I read your first email. Not sure how stable the output is across CVS versions/ports WRT leading slashes, might be a good idea to try to canonicalise the paths.

I am travelling at the moment, but I'll try and review the patch with the actual code. Some of the ugliness you're complaining about might be mine (plurals, and perhaps even the $#array) but I refuse to recognise the grep as mine.

Annotate might still put me to shame - perhaps I was drunk?

cheers,

-- 
-----------------------------------------------------------------------
Martin @ Catalyst .Net .NZ  Ltd, PO Box 11-053, Manners St,  Wellington
WEB: http://catalyst.net.nz/           PHYS: Level 2, 150-154 Willis St
NZ: +64(4)916-7224    MOB: +64(21)364-017    UK: 0845 868 5733 ext 7224
      Make things as simple as possible, but no simpler - Einstein
-----------------------------------------------------------------------