git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/9] Allow callers of unpack_trees() to handle failure

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Feb 5, 2008, 01:11 UTC
Message-ID
<alpine.LSU.1.00.0802050107440.8543@racer.site>
In-Reply-To
<alpine.LNX.1.00.0802041334450.13593@iabervon.org>
Hi,
On Mon, 4 Feb 2008, Daniel Barkalow wrote:
> Return an error from unpack_trees() instead of calling die(), and exit
> with an error in read-tree and builtin-commit.

Technically, there is still a possibility that an xcalloc() fails with a die(), but I agree that it is a good change.

BTW after the whole series (was too lazy to check the individual patches), I count one instance in builtin-checkout.c and two in diff-lib.c where unpack_trees()' return value is not checked. Is this intended?

Ciao, Dscho

Previous: Daniel BarkalowNext: Daniel Barkalow
Message 2 of 4 in “Allow callers of unpack_trees() to handle failure”
  1. 1/9 Allow callers of unpack_trees() to handle failureDaniel Barkalow, Feb 4, 2008
  2. Johannes SchindelinFeb 5, 2008
  3. Daniel BarkalowFeb 5, 2008
  4. Junio C HamanoFeb 5, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.