git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/9] Allow callers of unpack_trees() to handle failure

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 5, 2008, 23:43 UTC
Message-ID
<7vd4rb7yvk.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<alpine.LNX.1.00.0802051428180.13593@iabervon.org>
Daniel Barkalow <barkalow@iabervon.org> writes:
Show 10 quoted lines
> On Tue, 5 Feb 2008, Johannes Schindelin wrote:
> ...
>> BTW after the whole series (was too lazy to check the individual 
>> patches), I count one instance in builtin-checkout.c and two in diff-lib.c 
>> where unpack_trees()' return value is not checked.  Is this intended?
>
> ..., but it's probably best to check and 
> exit anyway, if only in the conversion commit. (If we remove the check 
> afterward, there will be a change in the history that documents that we 
> don't need to check)
I think that is a sensible thing to do.
Previous: Daniel Barkalow
Message 4 of 4 in “Allow callers of unpack_trees() to handle failure”
  1. 1/9 Allow callers of unpack_trees() to handle failureDaniel Barkalow, Feb 4, 2008
  2. Johannes SchindelinFeb 5, 2008
  3. Daniel BarkalowFeb 5, 2008
  4. Junio C HamanoFeb 5, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.