From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Tue, 05 Feb 2008 01:11:02 GMT
Subject: Re: [PATCH 1/9] Allow callers of unpack_trees() to handle failure
Message-ID: <alpine.LSU.1.00.0802050107440.8543@racer.site>
In-Reply-To: <alpine.LNX.1.00.0802041334450.13593@iabervon.org>

Hi,

On Mon, 4 Feb 2008, Daniel Barkalow wrote:

> Return an error from unpack_trees() instead of calling die(), and exit
> with an error in read-tree and builtin-commit.

Technically, there is still a possibility that an xcalloc() fails with a 
die(), but I agree that it is a good change.

BTW after the whole series (was too lazy to check the individual 
patches), I count one instance in builtin-checkout.c and two in diff-lib.c 
where unpack_trees()' return value is not checked.  Is this intended?

Ciao,
Dscho