git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] fsck_commit: remove duplicate tests

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Feb 4, 2008, 00:04 UTC
Message-ID
<alpine.LSU.1.00.0802040003360.7372@racer.site>
In-Reply-To
<7v3as9r3r2.fsf@gitster.siamese.dyndns.org>
Hi,
On Sun, 3 Feb 2008, Junio C Hamano wrote:
Show 9 quoted lines
> Martin Koegler <mkoegler@auto.tuwien.ac.at> writes:
> 
> > All tests on the commit buffer in fsck_cmd are ready done by 
> > parse_commit_buffer.
> >
> > This patch rips out all redundant tests.
> 
> As I believe in belt-and-suspenders when it comes to validation, I am 
> somewhat uneasy with this change.

Besides, should we really change fsck? It's not _that_ much of a performance-critical operation. Accuracy is much more important.

fsck is the reason I trust git with my data.

Ciao, Dscho

Previous: Junio C HamanoNext: Martin Koegler
Message 5 of 7 in “git-fsck: report missing author/commit line in a commit as an error”
  1. 1/3 git-fsck: report missing author/commit line in a commit as an errorMartin Koegler, Feb 3, 2008
  2. 2/3 fsck_commit: remove duplicate testsMartin Koegler, Feb 3, 2008
  3. 3/3 parse_object_buffer: don't ignore errors from the object specific parsing functionsMartin Koegler, Feb 3, 2008
  4. Junio C HamanoFeb 3, 2008
  5. Johannes SchindelinFeb 4, 2008
  6. Martin KoeglerFeb 4, 2008
  7. Junio C HamanoFeb 4, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.