Re: [PATCH 2/3] fsck_commit: remove duplicate tests

From: Martin Koegler <mkoegler@auto.tuwien.ac.at>
Date: Feb 4, 2008, 07:06 UTC
Message-ID: <20080204070600.GA30099@auto.tuwien.ac.at>
In-Reply-To: <alpine.LSU.1.00.0802040003360.7372@racer.site>

On Mon, Feb 04, 2008 at 12:04:31AM +0000, Johannes Schindelin wrote:

Show 15 quoted lines

> On Sun, 3 Feb 2008, Junio C Hamano wrote:
> > Martin Koegler <mkoegler@auto.tuwien.ac.at> writes:
> > 
> > > All tests on the commit buffer in fsck_cmd are ready done by 
> > > parse_commit_buffer.
> > >
> > > This patch rips out all redundant tests.
> > 
> > As I believe in belt-and-suspenders when it comes to validation, I am 
> > somewhat uneasy with this change.
> 
> Besides, should we really change fsck?  It's not _that_ much of a 
> performance-critical operation.  Accuracy is much more important.
> 
> fsck is the reason I trust git with my data.

Then please drop this patch. I hope the other two patches are OK.

mfg Martin Kögler