From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mon, 04 Feb 2008 00:04:31 GMT
Subject: Re: [PATCH 2/3] fsck_commit: remove duplicate tests
Message-ID: <alpine.LSU.1.00.0802040003360.7372@racer.site>
In-Reply-To: <7v3as9r3r2.fsf@gitster.siamese.dyndns.org>

Hi,

On Sun, 3 Feb 2008, Junio C Hamano wrote:

> Martin Koegler <mkoegler@auto.tuwien.ac.at> writes:
> 
> > All tests on the commit buffer in fsck_cmd are ready done by 
> > parse_commit_buffer.
> >
> > This patch rips out all redundant tests.
> 
> As I believe in belt-and-suspenders when it comes to validation, I am 
> somewhat uneasy with this change.

Besides, should we really change fsck?  It's not _that_ much of a 
performance-critical operation.  Accuracy is much more important.

fsck is the reason I trust git with my data.

Ciao,
Dscho