Re: [PATCH] http-push: making HTTP push more robust and more user-friendly

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 21, 2008, 12:17 UTC
Message-ID: <alpine.LSU.1.00.0801211212010.5731@racer.site>
In-Reply-To: <7vabmzzbcc.fsf@gitster.siamese.dyndns.org>

Hi,

On Mon, 21 Jan 2008, Junio C Hamano wrote:

Show 18 quoted lines

> Grégoire Barbier <devel@gbarbier.org> writes:
> 
> > Junio C Hamano a écrit :
> >> Thanks for correction.  I need to update Release Notes...
> >
> > Curl 7.16 has been released in october 2006 
> > (http://curl.haxx.se/changes.html), rather than 2003 like for 7.10.
> >
> > The consequences is that a lot of not so old distributions may be 
> > concerned. I only checked Fedora, which does not provide curl > 7.15 
> > before Fedora 7 (issued late may 2007).
> >
> > (BTW you may guess well that I'm using a Fedora Core 6 for my git 
> > patches...)
> 
> Now, that means the patch is not quite good for 1.5.4, and if we want to 
> keep http-push alive (I do not very much care about it myself, though), 
> and make it usable, we would need to fix it for non MULTI case.

IMHO it is safer to disable it for curl < 7.0xa -- even if it affects a number of distros -- than to give the illusion that it works, when it does not.

As for fixing it in the non-MULTI case, I have a hunch that Mike's cleanups will help that, but that this is a 1.5.5 feature.

So, I would like to read in the ReleaseNotes something like this:

-- snip -- Support for pushing via HTTP was broken with curl versions prior to 7.16, so we disabled it for now. However, it is likely that a major cleanup of the http transport code -- scheduled after the release of git 1.5.4 -- will be supported with more curl versions. -- snap --

Ciao, Dscho