git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] http-push: making HTTP push more robust and more user-friendly

From
Mike Hommey <mh@glandium.org>
Date
Jan 21, 2008, 20:29 UTC
Message-ID
<20080121202953.GA18440@glandium.org>
In-Reply-To
<7vejcbx795.fsf@gitster.siamese.dyndns.org>
On Mon, Jan 21, 2008 at 12:18:14PM -0800, Junio C Hamano wrote:
Show 25 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > IMHO it is safer to disable it for curl < 7.0xa -- even if it affects a 
> > number of distros -- than to give the illusion that it works, when it does 
> > not.
> >
> > As for fixing it in the non-MULTI case, I have a hunch that Mike's 
> > cleanups will help that, but that this is a 1.5.5 feature.
> >
> > So, I would like to read in the ReleaseNotes something like this:
> >
> > -- snip --
> > Support for pushing via HTTP was broken with curl versions prior to 7.16, 
> > so we disabled it for now.  However, it is likely that a major cleanup of 
> > the http transport code -- scheduled after the release of git 1.5.4 -- 
> > will be supported with more curl versions.
> > -- snap --
> 
> That's tempting but I suspect that it might be a wrong approach.
> 
> I think two important questions are:
> 
>  * Do we know that the current code is broken for everybody, or
>    just broken for the majority of people who do nontrivial
>    things?
IIRC, http-push simply doesn't work without CURL_MULTI. 
>  * Is the code in 1.5.3.8 any better?  IOW, did we make it worse
>    during 1.5.4 cycle?

Changes in http-push.c since 1.5.3.8 mostly involve cleanup. It didn't change anything about CURL_MULTI or lack thereof.

Mike
Previous: Junio C HamanoNext: Johannes Schindelin
Message 16 of 24 in “http-push: making HTTP push more robust and more user-friendly”
  1. http-push: making HTTP push more robust and more user-friendlyGrégoire Barbier, Jan 13, 2008
  2. http-push: fix webdav lock leak.Grégoire Barbier, Jan 13, 2008
  3. http-push: disable http-push without USE_CURL_MULTIGrégoire Barbier, Jan 13, 2008
  4. Junio C HamanoJan 13, 2008
  5. Johannes SchindelinJan 14, 2008
  6. Junio C HamanoJan 14, 2008
  7. Johannes SchindelinJan 14, 2008
  8. Grégoire BarbierJan 19, 2008
  9. Johannes SchindelinJan 19, 2008
  10. Grégoire BarbierJan 21, 2008
  11. Junio C HamanoJan 21, 2008
  12. Grégoire BarbierJan 21, 2008
  13. Junio C HamanoJan 21, 2008
  14. Johannes SchindelinJan 21, 2008
  15. Junio C HamanoJan 21, 2008
  16. Mike HommeyJan 21, 2008
  17. Johannes SchindelinJan 22, 2008
  18. Junio C HamanoJan 22, 2008
  19. Johannes SchindelinJan 22, 2008
  20. Junio C HamanoJan 22, 2008
  21. Johannes SchindelinJan 22, 2008
  22. Daniel BarkalowJan 21, 2008
  23. Junio C HamanoJan 21, 2008
  24. Grégoire BarbierJan 21, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.