Re: [PATCH] http-push: making HTTP push more robust and more user-friendly

> Johannes Schindelin a écrit :
> >  It gives a better warning if the URL cannot be accessed, alright. But
> >  I hate the fact that it introduces yet another function which does a
> >  bunch of curl_easy_setopt()s only to start an active slot and check
> >  for errors.
> > 
> >  Currently, I am not familiar enough with http-push.c to suggest a
> >  proper alternative, but I suspect that the return values of the
> >  _existing_ calls to curl should know precisely why the requests
> >  failed, and _this_ should be reported.
> 
> Mike Hommey a écrit :
> > FWIW, I have a work in progress refactoring the http code, avoiding a 
> > great amount of curl_easy_setopt()s and simplifying the whole thing. 
> > It's been sitting on my hard drive during my (quite long) vacation. I 
> > will probably start working again on this soonish.
> 
> 4) I agree with Johannes. However I am not familiar enough with curl to 
> write the proper alternative. I create the new function by copy/paste of 
> an existing one. I'm not 100% sure that it has no resource leaks or 
> other bugs, but it's called only once at http-push start, and thus is 
> likely not to do heavy damage...