Re: [PATCH] http-push and http-fetch: handle URLs without leading /
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jan 19, 2008, 23:16 UTC
- Message-ID
- <alpine.LSU.1.00.0801192315260.5731@racer.site>
- In-Reply-To
- <20080119152947.GA26553@glandium.org>
Hi,
On Sat, 19 Jan 2008, Mike Hommey wrote:
Show 16 quoted lines
> On Sat, Jan 19, 2008 at 04:22:50PM +0100, Grégoire Barbier wrote: > > Since HTTP/302 is not handled in the git code calling curl, URLs > > without leading / used to lead to frozen git-fetch or git-push with no > > error message. > > > > Furthermore, http-push freeze forces the user to interrupt it (^C) and > > therefore to leave a dandling webdav lock that makes the remote > > repository un-pushable for 10 minutes. > > > > The patch does not make curl calls handle HTTP/302 but instead adds a > > / at the end of URLs that does not have it yet. > > Actually, it would be much better to do just that, i.e. handle HTTP 302 > return codes. I suspect there may be other cases leading to similar dead > locks with other HTTP codes. But that might just be easier to deal with > once my refactoring will be done ;)
Independently, it seems a good idea to not try a URL we _know_ will fail (read: redirect).
Ciao, Dscho