git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] http-push and http-fetch: handle URLs without leading /

From
Mike Hommey <mh@glandium.org>
Date
Jan 19, 2008, 15:29 UTC
Message-ID
<20080119152947.GA26553@glandium.org>
In-Reply-To
<1200756171-11696-4-git-send-email-gb@gbarbier.org>
On Sat, Jan 19, 2008 at 04:22:50PM +0100, Grégoire Barbier wrote:
Show 9 quoted lines
> Since HTTP/302 is not handled in the git code calling curl, URLs without
> leading / used to lead to frozen git-fetch or git-push with no error message.
> 
> Furthermore, http-push freeze forces the user to interrupt it (^C) and
> therefore to leave a dandling webdav lock that makes the remote repository
> un-pushable for 10 minutes.
> 
> The patch does not make curl calls handle HTTP/302 but instead adds a / at
> the end of URLs that does not have it yet.

Actually, it would be much better to do just that, i.e. handle HTTP 302 return codes. I suspect there may be other cases leading to similar dead locks with other HTTP codes. But that might just be easier to deal with once my refactoring will be done ;)

Mike
Previous: Junio C HamanoNext: Johannes Schindelin
Message 9 of 13 in “http-push: fix webdav lock leak.”
  1. http-push: fix webdav lock leak.Grégoire Barbier, Jan 19, 2008
  2. http-push: fail when info/refs exists and is already lockedGrégoire Barbier, Jan 19, 2008
  3. http-push: more explicit error message with bad URL or passwordGrégoire Barbier, Jan 19, 2008
  4. http-push and http-fetch: handle URLs without leading /Grégoire Barbier, Jan 19, 2008
  5. added #define DEFAULT_MAX_REQUESTS for USE_CURL_MULTI modeGrégoire Barbier, Jan 19, 2008
  6. Junio C HamanoJan 21, 2008
  7. Grégoire BarbierJan 21, 2008
  8. Junio C HamanoJan 21, 2008
  9. Mike HommeyJan 19, 2008
  10. Johannes SchindelinJan 19, 2008
  11. Johannes SchindelinJan 19, 2008
  12. Junio C HamanoJan 20, 2008
  13. Johannes SchindelinJan 19, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.