git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] added #define DEFAULT_MAX_REQUESTS for USE_CURL_MULTI mode

From
GBGrégoire Barbier <gb@gbarbier.org>
Date
Jan 21, 2008, 09:57 UTC
Message-ID
<47946C95.4080607@gbarbier.org>
In-Reply-To
<7v1w8c6nnm.fsf@gitster.siamese.dyndns.org>
Junio C Hamano a écrit :
Show 29 quoted lines
> Grégoire Barbier <gb@gbarbier.org> writes:
>   
>> From: Gregoire Barbier <gb@gbarbier.org>
>>
>> I'm not sure of which value is the good one, but 4 seems good since it's
>> not very high which would lead to resouce consumption problems.
>> ---
>>  http.c |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/http.c b/http.c
>> index 8b04ae9..7b1bcb8 100644
>> --- a/http.c
>> +++ b/http.c
>> @@ -4,6 +4,7 @@ int data_received;
>>  int active_requests = 0;
>>  
>>  #ifdef USE_CURL_MULTI
>> +#define DEFAULT_MAX_REQUESTS 4
>>  static int max_requests = -1;
>>  static CURLM *curlm;
>>  #endif
>>     
>
> Why is this needed?
>
> How does this interact with an existing #define in http.h that
> defines it to 5?
>   

Ok, please forget my patch and forgive my stupidity, I've juste realized why I needed to define -DUSE_CURL_MULTI by hand in the Makefile, I'm so stupid...

I will answers you other mail and Johannes' later.
-- 
Grégoire Barbier - gb à gbarbier.org - +33 6 21 35 73 49
Previous: Junio C HamanoNext: Junio C Hamano
Message 7 of 13 in “http-push: fix webdav lock leak.”
  1. http-push: fix webdav lock leak.Grégoire Barbier, Jan 19, 2008
  2. http-push: fail when info/refs exists and is already lockedGrégoire Barbier, Jan 19, 2008
  3. http-push: more explicit error message with bad URL or passwordGrégoire Barbier, Jan 19, 2008
  4. http-push and http-fetch: handle URLs without leading /Grégoire Barbier, Jan 19, 2008
  5. added #define DEFAULT_MAX_REQUESTS for USE_CURL_MULTI modeGrégoire Barbier, Jan 19, 2008
  6. Junio C HamanoJan 21, 2008
  7. Grégoire BarbierJan 21, 2008
  8. Junio C HamanoJan 21, 2008
  9. Mike HommeyJan 19, 2008
  10. Johannes SchindelinJan 19, 2008
  11. Johannes SchindelinJan 19, 2008
  12. Junio C HamanoJan 20, 2008
  13. Johannes SchindelinJan 19, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.