Re: [PATCH] Fixup no-progress for fetch & clone

From: Nicolas Pitre <nico@cam.org>
Date: Feb 24, 2007, 02:28 UTC
Message-ID: <alpine.LRH.0.82.0702232123110.29426@xanadu.home>
In-Reply-To: <Pine.LNX.4.63.0702240314250.22628@wbgn013.biozentrum.uni-wuerzburg.de>

On Sat, 24 Feb 2007, Johannes Schindelin wrote:

Show 15 quoted lines

> Hi,
> 
> On Fri, 23 Feb 2007, Nicolas Pitre wrote:
> 
> > On Sat, 24 Feb 2007, Johannes Schindelin wrote:
> > 
> > > Since most servers will not have a no-progress aware upload-pack, how 
> > > about this? (It is slightly ugly, but at least works...)
> > 
> > Just slightly.
> > 
> > Why not simply filtering any string that ends in '\r' ?
> 
> As I mentioned in another mail, I find this issue not so ugly as that the 
> patch touches a totally unrelated file, builtin-archive.c.

Actually that is not the part that bothered me at all.

What really bothered me is the implicit knowledge added to the sideband stuff about "done\r".

And since all progress strings ar likely to end in '\r' for easy redrawing then I think your patch would be so much cleaner if you'd only discard any remote string that ends in \r, or only contains a single \n. After all those are the strings you don't want to see in your log files.

And I would do that and _only_ that to supress progress. No messing around with protocol extensions. Just filter out the unwanted messages locally and be happy.

Nicolas